Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@radix-ui/react-dropdown-menu] lack of "dir" prop in Content #312

Closed
wants to merge 1 commit into from
Closed

[@radix-ui/react-dropdown-menu] lack of "dir" prop in Content #312

wants to merge 1 commit into from

Conversation

Luccasoli
Copy link

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code.
  • Include the URL where we can test the change in the body of your PR.

This pull request:

  • Fixes a bug
  • Adds additional features/functionality
  • Updates documentation or example code
  • Other

@vercel
Copy link

vercel bot commented Dec 16, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/modulz/radix-website/BR53jJA4ZWd16aDBmSmzri3s9bP3
✅ Preview: https://radix-website-git-fork-luccasoli-patch-1.modulz-deploys.com

@jjenzz
Copy link
Contributor

jjenzz commented Dec 20, 2021

@Luccasoli Thanks for contributing. The dir "prop" is a HTML attribute though.

We only document custom props because all of our components support applicable HTML attributes which would be a lot to document as individual line items. I've been meaning to update the docs to clear this up as it isn't obvious that we support these (or all of React's built in Synthetic Events) unless using TypeScript.

I'll close this for now and create a Github Issue to remind us to make this all a bit clearer because the solution described above would require some design input.

@jjenzz jjenzz closed this Dec 20, 2021
@jjenzz jjenzz mentioned this pull request Dec 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitgrelard benoitgrelard Awaiting requested review from benoitgrelard

@jjenzz jjenzz Awaiting requested review from jjenzz

@peduarte peduarte Awaiting requested review from peduarte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Luccasoli @jjenzz